This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Makes site protocol-neutral (possible to run over HTTP or HTTPS) #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very sensible improvements—thank you, @konklone! |
|
+1 Should be using ssl by default in all gov work... |
|
And just to note, this PR doesn't force the site to run over HTTPS, or change links to prefer the HTTPS version. It fixes incompatibilities, so that the project could start listing its official URL as HTTPS without any trouble, if it wanted to. |
|
Looks good. Thanks a bunch, Eric. |
|
very helpful improvement, thanks @konklone |
haleyvandyck
pushed a commit
that referenced
this pull request
Apr 7, 2014
Makes site protocol-neutral (possible to run over HTTP or HTTPS)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you visit the site right now over HTTPS, at https://project-open-data.github.io, you'll see it renders incorrectly, as some stylesheets are not loaded, and the Github "Fork" button at the bottom is missing.
This PR fixes those, so that the site will run properly over either HTTP or HTTPS. This is done by:
root_urlof the site protocol-relative, a common practice to make URLs resolve to whatever protocol the site they're contained in is currently using.